Skip to content

refactor: replace @vercel/kv with node-redis client#330

Closed
drankou wants to merge 4 commits into
mainfrom
refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835
Closed

refactor: replace @vercel/kv with node-redis client#330
drankou wants to merge 4 commits into
mainfrom
refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835

Conversation

@drankou

@drankou drankou commented May 15, 2026

Copy link
Copy Markdown
Contributor

Replace @vercel/kv with node-redis. KV stays optional; the
public API (isKvConfigured / pingKv / getKvValue / setKvValue)
is unchanged, so call sites and existing test mocks don't need updates.

@vercel/kv only speaks the Upstash REST API. node-redis works
against any RESP endpoint — local Redis, ElastiCache, Redis Cloud,
Upstash TCP, Vercel KV's KV_URL, Dragonfly, etc.

Env change ⚠️
KV_REST_API_URL + KV_REST_API_TOKEN → single REDIS_URL
(redis:// or rediss://).

@drankou drankou requested a review from ben-fornefeld as a code owner May 15, 2026 14:16
@linear-code

linear-code Bot commented May 15, 2026

Copy link
Copy Markdown

ENG-3835

@cla-bot cla-bot Bot added the cla-signed label May 15, 2026
@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 10, 2026 2:10pm
web-juliett Error Error Jun 10, 2026 2:10pm

Request Review

Comment thread src/core/shared/clients/kv.ts Outdated
@ben-fornefeld

ben-fornefeld commented May 20, 2026

Copy link
Copy Markdown
Member

please merge #326 before and re-point this branch to main, we'll have to coordinate deployment on this one with prod environment

@drankou drankou force-pushed the make-redis-optional-for-local-development-eng-3976 branch from e80086f to 08cd97b Compare May 22, 2026 13:48
Base automatically changed from make-redis-optional-for-local-development-eng-3976 to main May 22, 2026 14:18
@drankou drankou force-pushed the refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835 branch from 11d4357 to 0a399a8 Compare May 22, 2026 14:20
@drankou drankou force-pushed the refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835 branch from 0a399a8 to f96ba2d Compare June 10, 2026 12:39
@drankou drankou requested a review from huv1k as a code owner June 10, 2026 12:39
@drankou drankou force-pushed the refactor-dependency-on-vercelkv-in-favor-of-general-redis-eng-3835 branch from d9d04af to bcd7b26 Compare June 10, 2026 12:48
@tvi

tvi commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Closing this PR. Redis is no longer used.

@tvi tvi closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants